Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase read time out for Guard #343

Merged
merged 1 commit into from
Sep 17, 2022

Conversation

krdhruva
Copy link
Contributor

We have been observing various client connection errors due to default values in http client & server.

stream error: stream ID 1; INTERNAL_ERROR; received from peer -> due to aggressive read time out
connect: cannot assign requested address -> due to default MaxIdleConnsPerHost.

Raising PR to fix these by making read time out value configurable.

@krdhruva krdhruva requested a review from a team as a code owner September 16, 2022 15:34
@krdhruva krdhruva force-pushed the streamReadTimeoutFix branch from 10463cc to 8302e95 Compare September 16, 2022 15:35
Signed-off-by: Krupesh Dhruva <krdhruva@microsoft.com>
@krdhruva krdhruva force-pushed the streamReadTimeoutFix branch from 8302e95 to 25205cd Compare September 16, 2022 15:37
Copy link
Contributor

@weinong weinong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tamalsaha tamalsaha merged commit e38e221 into kubeguard:master Sep 17, 2022
@tamalsaha
Copy link
Contributor

Released https://github.com/kubeguard/guard/releases/tag/v0.11.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants